[coreboot-gerrit] Change in ...coreboot[master]: nb/intel/gm45: Make fetching the blc_pwm freq global

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29925 )

Change subject: nb/intel/gm45: Make fetching the blc_pwm freq global
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/29925/1/src/northbridge/intel/gm45/gma.c 
File src/northbridge/intel/gm45/gma.c:

https://review.coreboot.org/#/c/29925/1/src/northbridge/intel/gm45/gma.c@44 
PS1, Line 44: char edid_ascii_string[EDID_ASCII_STRING_LENGTH + 1];
static?


https://review.coreboot.org/#/c/29925/1/src/northbridge/intel/gm45/gma.c@673 
PS1, Line 673: int get_blc_pwm_freq_value(void)
Alternative to caching the string: Call it with NULL for the VBT
stuff and make the check below:

    if (blc_pwm_freq > 0 || !edid_ascii_string)

Reasoning: If the lookup would succeed `blc_pwm_freq` would already
be set, if not, there's no need to try again.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29925
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id3f6ba3ae31a5ab47f44d207678c1c4a6a43b7ec
Gerrit-Change-Number: 29925
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Thu, 29 Nov 2018 13:09:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181129/518624e3/attachment.html>