[coreboot-gerrit] Change in ...coreboot[master]: arch/x86/Makefile.inc: Fix typo

Patrick Georgi (Code Review) gerrit at coreboot.org
Thu Nov 29 10:29:06 CET 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29878 )

Change subject: arch/x86/Makefile.inc: Fix typo
......................................................................

arch/x86/Makefile.inc: Fix typo

Link 32bit ramstage if CONFIG_ARCH_RAMSTAGE_X86_32 is set.
Required for 64bit ramstage support.

Change-Id: Ib0c06f494dcc035d182ab9034e910ceceb236198
Signed-off-by: Patrick Rudolph <siro at das-labor.org>
Reviewed-on: https://review.coreboot.org/c/29878
Reviewed-by: Arthur Heymans <arthur at aheymans.xyz>
Reviewed-by: Angel Pons <th3fanbus at gmail.com>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M src/arch/x86/Makefile.inc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved
  Angel Pons: Looks good to me, but someone else must approve



diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc
index fcc57c5..c5cf625 100644
--- a/src/arch/x86/Makefile.inc
+++ b/src/arch/x86/Makefile.inc
@@ -398,7 +398,7 @@
 
 $(objgenerated)/ramstage.o: $$(ramstage-objs) $(COMPILER_RT_ramstage) $$(ramstage-libs)
 	@printf "    CC         $(subst $(obj)/,,$(@))\n"
-ifeq ($(CONFIG_ARCH_ROMSTAGE_X86_32),y)
+ifeq ($(CONFIG_ARCH_RAMSTAGE_X86_32),y)
 	$(LD_ramstage) -m elf_i386 -r -o $@ $(COMPILER_RT_FLAGS_ramstage) --whole-archive --start-group $(filter-out %.ld,$(ramstage-objs)) $(ramstage-libs) --no-whole-archive $(COMPILER_RT_ramstage) --end-group
 else
 	$(LD_ramstage) -m elf_x86_64 -r -o $@ $(COMPILER_RT_FLAGS_ramstage) --whole-archive --start-group $(filter-out %.ld,$(ramstage-objs)) $(ramstage-libs) --no-whole-archive $(COMPILER_RT_ramstage) --end-group

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29878
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0c06f494dcc035d182ab9034e910ceceb236198
Gerrit-Change-Number: 29878
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181129/90fa1c90/attachment.html>


More information about the coreboot-gerrit mailing list