[coreboot-gerrit] Change in ...coreboot[master]: arch/x86/acpigen.c: Add a method to notify all CPU cores

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29895 )

Change subject: arch/x86/acpigen.c: Add a method to notify all CPU cores
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://review.coreboot.org/#/c/29895/2/src/arch/x86/acpigen.c 
File src/arch/x86/acpigen.c:

https://review.coreboot.org/#/c/29895/2/src/arch/x86/acpigen.c@375 
PS2, Line 375: 	int coreID;
I know it might have been me who named it like that... but
give it a proper identifier? e.g. core_id?


https://review.coreboot.org/#/c/29895/2/src/arch/x86/acpigen.c@377 
PS2, Line 377: \\_PR.
NB. Why the absolute path? At some point we might want to just ensure
that these functions are called in the proper scope. CONFIG_ACPI_CPU_
STRING would have to change too...


https://review.coreboot.org/#/c/29895/2/src/arch/x86/acpigen.c@380 
PS2, Line 380: snprintf(buffer, sizeof(buffer), "\\_PR.CP%c%c",
             : 			 '0' + coreID / 10, '0' + coreID % 10);
snprintf(buffer, sizeof(buffer), CONFIG_ACPI_CPU_STRING, coreID);



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29895
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If8b07fdcec51c344a82309d4af3b6127ad758baf
Gerrit-Change-Number: 29895
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 28 Nov 2018 14:05:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181128/469e23eb/attachment.html>