[coreboot-gerrit] Change in ...coreboot[master]: src: Remove duplicated round up function

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Wed Nov 28 13:11:22 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29847 )

Change subject: src: Remove duplicated round up function
......................................................................


Patch Set 6:

(2 comments)

https://review.coreboot.org/#/c/29847/6/src/soc/nvidia/tegra210/include/soc/clock.h 
File src/soc/nvidia/tegra210/include/soc/clock.h:

https://review.coreboot.org/#/c/29847/6/src/soc/nvidia/tegra210/include/soc/clock.h@327 
PS6, Line 327: #define get_i2c_clk_div(src,freq) (DIV_ROUND_UP(src, (freq) * (0x19 + 1) * 8) - 1)
line over 80 characters


https://review.coreboot.org/#/c/29847/6/src/soc/nvidia/tegra210/include/soc/clock.h@327 
PS6, Line 327: #define get_i2c_clk_div(src,freq) (DIV_ROUND_UP(src, (freq) * (0x19 + 1) * 8) - 1)
space required after that ',' (ctx:VxV)



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29847
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9aabc3fbe7834834c92d6ba59ff0005986622a34
Gerrit-Change-Number: 29847
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Comment-Date: Wed, 28 Nov 2018 12:11:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181128/39f1ecf0/attachment.html>


More information about the coreboot-gerrit mailing list