[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/common/acpi: Add common CPU methods

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29754 )

Change subject: soc/intel/common/acpi: Add common CPU methods
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> It is a good idea, but I think it is a much larger change than just fixing the cannonlake bug where these methods don't exist, which I could do instead of refactoring it into common code if we want to instead push for a change in this direction.
> 
> However, I think calling back into an SSDT from the DSDT is still not allowed by the linux kernel, and currently all the DPTF code is in the DSDT...

calling SSDT from DSDT works just fine.


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29754
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd467ef84a391698cd395172c3f0d4e801bdd09b
Gerrit-Change-Number: 29754
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Comment-Date: Wed, 28 Nov 2018 10:57:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181128/aacdedb9/attachment.html>