[coreboot-gerrit] Change in ...coreboot[master]: siemens/mc_apl5: Set bus master bit for on-board PCI device

Mario Scheithauer (Code Review) gerrit at coreboot.org
Wed Nov 28 09:43:45 CET 2018


Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29881 )

Change subject: siemens/mc_apl5: Set bus master bit for on-board PCI device
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/29881/1/src/mainboard/siemens/mc_apl1/variants/mc_apl5/mainboard.c 
File src/mainboard/siemens/mc_apl1/variants/mc_apl5/mainboard.c:

https://review.coreboot.org/#/c/29881/1/src/mainboard/siemens/mc_apl1/variants/mc_apl5/mainboard.c@37 
PS1, Line 37: ;
> Not needed as it will be set explicitly to a value on line 82.
Done



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29881
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ab40e34253c20adaacfdf42050314e06547eefb
Gerrit-Change-Number: 29881
Gerrit-PatchSet: 3
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 28 Nov 2018 08:43:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh <werner.zeh at siemens.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181128/6f37e534/attachment.html>


More information about the coreboot-gerrit mailing list