[coreboot-gerrit] Change in ...coreboot[master]: siemens/mc_apl5: Set bus master bit for on-board PCI device

Mario Scheithauer (Code Review) gerrit at coreboot.org
Wed Nov 28 09:16:05 CET 2018


Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29881


Change subject: siemens/mc_apl5: Set bus master bit for on-board PCI device
......................................................................

siemens/mc_apl5: Set bus master bit for on-board PCI device

There is an on-board PCI device where bus master has to be enabled in
PCI configuration space. As there is no need for a complete PCI driver
for this device just set the bus master bit in mainboard_final().

Change-Id: I4ab40e34253c20adaacfdf42050314e06547eefb
Signed-off-by: Mario Scheithauer <mario.scheithauer at siemens.com>
---
M src/mainboard/siemens/mc_apl1/variants/mc_apl5/mainboard.c
1 file changed, 10 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/29881/1

diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/mainboard.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/mainboard.c
index 6d22fd9..5ad3172 100644
--- a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/mainboard.c
+++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/mainboard.c
@@ -15,6 +15,7 @@
 
 #include <bootstate.h>
 #include <console/console.h>
+#include <device/pci_def.h>
 #include <device/pci_ids.h>
 #include <device/pci_ops.h>
 #include <gpio.h>
@@ -33,6 +34,7 @@
 {
 	int status;
 	struct device *dev = NULL;
+	uint16_t cmd = 0;
 
 	/*
 	 * Set up the DP2LVDS converter.
@@ -73,6 +75,14 @@
 	 * The value 0x4a sets the swing level to 0.58 V.
 	 */
 	pcr_rmw32(PID_MODPHY, TX_DWORD3, (0x00 << 16), (0x4a << 16));
+
+	/* Set Master Enable for on-board PCI device. */
+	dev = dev_find_device(PCI_VENDOR_ID_SIEMENS, 0x403e, 0);
+	if (dev) {
+		cmd = pci_read_config16(dev, PCI_COMMAND);
+		cmd |= PCI_COMMAND_MASTER;
+		pci_write_config16(dev, PCI_COMMAND, cmd);
+	}
 }
 
 static void wait_for_legacy_dev(void *unused)

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29881
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ab40e34253c20adaacfdf42050314e06547eefb
Gerrit-Change-Number: 29881
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181128/2c8b9270/attachment.html>


More information about the coreboot-gerrit mailing list