[coreboot-gerrit] Change in ...coreboot[master]: cpu/x86/pae: Fix pointer casts

Patrick Rudolph (Code Review) gerrit at coreboot.org
Wed Nov 28 07:52:43 CET 2018


Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29876


Change subject: cpu/x86/pae: Fix pointer casts
......................................................................

cpu/x86/pae: Fix pointer casts

Required to compile the code in x86_64, even though it's never used.

Change-Id: I2be8ad8805804e4da52bdb02ab43cb833402f999
---
M src/cpu/x86/pae/pgtbl.c
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/29876/1

diff --git a/src/cpu/x86/pae/pgtbl.c b/src/cpu/x86/pae/pgtbl.c
index 728135d..2cc9ba6 100644
--- a/src/cpu/x86/pae/pgtbl.c
+++ b/src/cpu/x86/pae/pgtbl.c
@@ -135,10 +135,10 @@
 			memset(&pgtbl[index].pdp, 0, sizeof(pgtbl[index].pdp));
 			pd = pgtbl[index].pd;
 			pdp = pgtbl[index].pdp;
-			pdp[0].addr_lo = ((uint32_t)&pd[512*0])|1;
-			pdp[1].addr_lo = ((uint32_t)&pd[512*1])|1;
-			pdp[2].addr_lo = ((uint32_t)&pd[512*2])|1;
-			pdp[3].addr_lo = ((uint32_t)&pd[512*3])|1;
+			pdp[0].addr_lo = ((uintptr_t)&pd[512*0])|1;
+			pdp[1].addr_lo = ((uintptr_t)&pd[512*1])|1;
+			pdp[2].addr_lo = ((uintptr_t)&pd[512*2])|1;
+			pdp[3].addr_lo = ((uintptr_t)&pd[512*3])|1;
 			/* The first half of the page table is identity mapped
 			 */
 			for (i = 0; i < 1024; i++) {

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29876
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2be8ad8805804e4da52bdb02ab43cb833402f999
Gerrit-Change-Number: 29876
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181128/8a125fad/attachment-0001.html>


More information about the coreboot-gerrit mailing list