[coreboot-gerrit] Change in ...coreboot[master]: soc/{amd, intel}: Remove duplicated '&' on ptr's function

HAOUAS Elyes (Code Review) gerrit at coreboot.org
Tue Nov 27 12:25:18 CET 2018


HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29862


Change subject: soc/{amd,intel}: Remove duplicated '&' on ptr's function
......................................................................

soc/{amd,intel}: Remove duplicated '&' on ptr's function

Change-Id: I7a59fd2f370d2b0d830ca83be9a9bc1abe2750f5
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/soc/amd/stoneyridge/chip.c
M src/soc/intel/apollolake/chip.c
M src/soc/intel/denverton_ns/chip.c
M src/soc/intel/denverton_ns/systemagent.c
4 files changed, 14 insertions(+), 14 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/29862/1

diff --git a/src/soc/amd/stoneyridge/chip.c b/src/soc/amd/stoneyridge/chip.c
index 90b25bb..9743aa9 100644
--- a/src/soc/amd/stoneyridge/chip.c
+++ b/src/soc/amd/stoneyridge/chip.c
@@ -148,9 +148,9 @@
 
 struct chip_operations soc_amd_stoneyridge_ops = {
 	CHIP_NAME("AMD StoneyRidge SOC")
-	.enable_dev = &enable_dev,
-	.init = &soc_init,
-	.final = &soc_final
+	.enable_dev = enable_dev,
+	.init = soc_init,
+	.final = soc_final
 };
 
 static void earliest_ramstage(void *unused)
diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c
index 85fe30c..2bf8c9a 100644
--- a/src/soc/intel/apollolake/chip.c
+++ b/src/soc/intel/apollolake/chip.c
@@ -659,9 +659,9 @@
 
 struct chip_operations soc_intel_apollolake_ops = {
 	CHIP_NAME("Intel Apollolake SOC")
-	.enable_dev = &enable_dev,
-	.init = &soc_init,
-	.final = &soc_final
+	.enable_dev = enable_dev,
+	.init = soc_init,
+	.final = soc_final
 };
 
 static void drop_privilege_all(void)
diff --git a/src/soc/intel/denverton_ns/chip.c b/src/soc/intel/denverton_ns/chip.c
index d0a21ac..0f3c8a0 100644
--- a/src/soc/intel/denverton_ns/chip.c
+++ b/src/soc/intel/denverton_ns/chip.c
@@ -123,9 +123,9 @@
 
 struct chip_operations soc_intel_denverton_ns_ops = {
 	CHIP_NAME("Intel Denverton-NS SOC")
-	.enable_dev = &soc_enable_dev,
-	.init = &soc_init,
-	.final = &soc_final
+	.enable_dev = soc_enable_dev,
+	.init = soc_init,
+	.final = soc_final
 };
 
 static void soc_set_subsystem(struct device *dev, uint32_t vendor,
diff --git a/src/soc/intel/denverton_ns/systemagent.c b/src/soc/intel/denverton_ns/systemagent.c
index 6ffa2c7..b33a178 100644
--- a/src/soc/intel/denverton_ns/systemagent.c
+++ b/src/soc/intel/denverton_ns/systemagent.c
@@ -335,11 +335,11 @@
 }
 
 static struct device_operations systemagent_ops = {
-	.read_resources = &systemagent_read_resources,
-	.set_resources = &pci_dev_set_resources,
-	.enable_resources = &pci_dev_enable_resources,
-	.init = &systemagent_init,
-	.ops_pci = &soc_pci_ops,
+	.read_resources = systemagent_read_resources,
+	.set_resources = pci_dev_set_resources,
+	.enable_resources = pci_dev_enable_resources,
+	.init = systemagent_init,
+	.ops_pci = soc_pci_ops,
 };
 
 /* IDs for System Agent device of Intel Denverton SoC */

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29862
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a59fd2f370d2b0d830ca83be9a9bc1abe2750f5
Gerrit-Change-Number: 29862
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181127/1b78392a/attachment.html>


More information about the coreboot-gerrit mailing list