[coreboot-gerrit] Change in ...coreboot[master]: mb/google/poppy/variants/nami: Enable g2touch touchscreen device

Patrick Georgi (Code Review) gerrit at coreboot.org
Tue Nov 27 09:54:45 CET 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29768 )

Change subject: mb/google/poppy/variants/nami: Enable g2touch touchscreen device
......................................................................

mb/google/poppy/variants/nami: Enable g2touch touchscreen device

This change adds ACPI properties for GTCH7503 device.

BUG=b:119169362
BRANCH=firmware-nami-10775.B
TEST=Verify touchscreen works with this change

Change-Id: I26e16b7e118121b3dd9a88c76d04898b97753df0
Signed-off-by: Crystal Lin <crystal_lin at compal.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/29768
Reviewed-by: Furquan Shaikh <furquan at google.com>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M src/mainboard/google/poppy/variants/nami/devicetree.cb
1 file changed, 14 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved



diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb
index 49e35b2..edf7ed6 100644
--- a/src/mainboard/google/poppy/variants/nami/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb
@@ -346,6 +346,20 @@
 				register "hid_desc_reg_offset" = "0x20"
 				device i2c 20 on end
 			end
+			chip drivers/i2c/hid
+				register "generic.hid" = ""GTCH7503""
+				register "generic.desc" = ""G2TOUCH Touchscreen""
+				register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_E7_IRQ)"
+				register "generic.probed" = "1"
+				register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_B3)"
+				register "generic.reset_delay_ms" = "50"
+				register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B4)"
+				register "generic.enable_delay_ms" = "1"
+				register "generic.has_power_resource" = "1"
+				register "generic.disable_gpio_export_in_crs" = "1"
+				register "hid_desc_reg_offset" = "0x01"
+				device i2c 40 on end
+			end
 		end # I2C #0
 		device pci 15.1 on
 			chip drivers/i2c/generic

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29768
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26e16b7e118121b3dd9a88c76d04898b97753df0
Gerrit-Change-Number: 29768
Gerrit-PatchSet: 3
Gerrit-Owner: Crystal Lin <crystal_lin at compal.corp-partner.google.com>
Gerrit-Reviewer: Crystal Lin <crystal_lin at compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181127/cebfd3ef/attachment.html>


More information about the coreboot-gerrit mailing list