[coreboot-gerrit] Change in ...coreboot[master]: Documentation/../../dragonegg: Add dragonegg coreboot development doc...
Patrick Rudolph (Code Review)
gerrit at coreboot.org
Tue Nov 27 08:48:23 CET 2018
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29829 )
Change subject: Documentation/../../dragonegg: Add dragonegg coreboot development documentation
......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/#/c/29829/4/Documentation/mainboard/google/dragonegg.md
File Documentation/mainboard/google/dragonegg.md:
https://review.coreboot.org/#/c/29829/4/Documentation/mainboard/google/dragonegg.md@7
PS4, Line 7: .. Ice Lake coreboot development:doc: ‘../../soc/intel/iceLake_coreboot_development.md’
:doc:`../../soc/intel/icelake/iceLake_coreboot_development`
https://review.coreboot.org/#/c/29829/4/Documentation/mainboard/google/dragonegg.md@14
PS4, Line 14: .. Create coreboot Image:doc: ‘../../soc/intel/iceLake_coreboot_development.md’
You don't need to set a title, sphinx will automatically insert the referenced document title.
The correct path is:
:doc:`../../soc/intel/icelake/iceLake_coreboot_development`
https://review.coreboot.org/#/c/29829/4/Documentation/mainboard/google/dragonegg.md@19
PS4, Line 19: # echo "CONFIG_VENDOR_GOOGLE=y" > .config
```bash
```
Otherwise this renders are chapter title
--
To view, visit https://review.coreboot.org/c/coreboot/+/29829
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia15e317557a0893d9f80cc9e87c6b90c85b93dcf
Gerrit-Change-Number: 29829
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 27 Nov 2018 07:48:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181127/00b308fd/attachment.html>
More information about the coreboot-gerrit
mailing list