[coreboot-gerrit] Change in ...coreboot[master]: security/tpm: Fix TCPA log feature

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29563 )

Change subject: security/tpm: Fix TCPA log feature
......................................................................


Patch Set 23:

(6 comments)

https://review.coreboot.org/#/c/29563/20/src/commonlib/include/commonlib/tcpa_log_serialized.h 
File src/commonlib/include/commonlib/tcpa_log_serialized.h:

https://review.coreboot.org/#/c/29563/20/src/commonlib/include/commonlib/tcpa_log_serialized.h@21 
PS20, Line 21: #define MAX_TCPA_LOG_ENTRIES 50
> This is specific to coreboot proper's implementation and shouldn't necessarily be in here.
Done


https://review.coreboot.org/#/c/29563/20/src/commonlib/include/commonlib/tcpa_log_serialized.h@26 
PS20, Line 26: struct tcpa_entry {
> I don't see why this needs to be in the header since it's really dependent on the format string you  […]
Done


https://review.coreboot.org/#/c/29563/20/src/include/memlayout.h 
File src/include/memlayout.h:

https://review.coreboot.org/#/c/29563/20/src/include/memlayout.h@168 
PS20, Line 168: #define VBOOT2_TPM_LOG(addr, size) \
> Macros with multiple statements should be enclosed in a do - while loop
Done


https://review.coreboot.org/#/c/29563/20/src/include/memlayout.h@168 
PS20, Line 168: #define VBOOT2_TPM_LOG(addr, size) \
> macros should not use a trailing semicolon
Done


https://review.coreboot.org/#/c/29563/20/src/security/tpm/tspi/log.c 
File src/security/tpm/tspi/log.c:

https://review.coreboot.org/#/c/29563/20/src/security/tpm/tspi/log.c@79 
PS20, Line 79: 			memset(log_string, 0, sizeof(log_string));
> This needs to subtract j for proper length calculation.
Done


https://review.coreboot.org/#/c/29563/20/src/security/tpm/tspi/log.c@116 
PS20, Line 116: EST_MAX_LENGT
> MIN(digest_length, TCPA_DIGEST_MAX_LENGTH)
Done



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29563
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic93133531b84318f48940d34bded48cbae739c44
Gerrit-Change-Number: 29563
Gerrit-PatchSet: 23
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: David Hendricks <david.hendricks at gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Mon, 26 Nov 2018 21:45:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin <adurbin at chromium.org>
Comment-In-Reply-To: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181126/a7e9e995/attachment.html>