[coreboot-gerrit] Change in ...coreboot[master]: Documentation/../../icelake_rvp: Add RVP coreboot development documen...

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29828 )

Change subject: Documentation/../../icelake_rvp: Add RVP coreboot development documentation
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/29828/2/Documentation/mainboard/intel/icelake_rvp.md 
File Documentation/mainboard/intel/icelake_rvp.md:

https://review.coreboot.org/#/c/29828/2/Documentation/mainboard/intel/icelake_rvp.md@17 
PS2, Line 17: 
> https://review.coreboot. […]
I'm fine with that, but it's an extra step compared to these 3. To be honest, I disagree with the others that we need to explain this every. single. time.

Line 12 should be sufficient, as it explains the process: pick the board in Kconfig (by whatever means necessary), build, done. Maybe add "Following the instructions for Ice Lake, " before it so that the blobs thing is mentioned.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29828
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If063cbd3436d9ee107945f425a31ba0009039a1d
Gerrit-Change-Number: 29828
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 26 Nov 2018 16:45:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subrata.banik at intel.com>
Comment-In-Reply-To: Patrick Georgi <pgeorgi at google.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181126/f2279da1/attachment.html>