[coreboot-gerrit] Change in ...coreboot[master]: nb/amd/amdmct/{mct, mct_ddr3}: Replace MTRR addresses with macros

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29580 )

Change subject: nb/amd/amdmct/{mct,mct_ddr3}: Replace MTRR addresses with macros
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/29580/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/29580/2//COMMIT_MSG@9 
PS2, Line 9: Replace numbers by macro
Replace "magic" numbers with macros.

Also, normally the description should be longer then the title... add something else, maybe that the MTRR addresses are now publicly available?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29580
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I224136ed4a19199bae0223a1aae366b3dd4ef9cf
Gerrit-Change-Number: 29580
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 26 Nov 2018 15:39:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181126/f818467a/attachment.html>