[coreboot-gerrit] Change in ...coreboot[master]: src/mainboard/portwell/m107: Do initial mainboard commit

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Mon Nov 26 09:14:21 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29470 )

Change subject: src/mainboard/portwell/m107: Do initial mainboard commit
......................................................................


Patch Set 7:

(2 comments)

https://review.coreboot.org/#/c/29470/7/src/mainboard/portwell/m107/irqroute.h 
File src/mainboard/portwell/m107/irqroute.h:

https://review.coreboot.org/#/c/29470/7/src/mainboard/portwell/m107/irqroute.h@39 
PS7, Line 39: #define PCI_DEV_PIRQ_ROUTES \
Macros with complex values should be enclosed in parentheses


https://review.coreboot.org/#/c/29470/7/src/mainboard/portwell/m107/irqroute.h@60 
PS7, Line 60: #define PIRQ_PIC_ROUTES \
Macros with complex values should be enclosed in parentheses



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29470
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d3173fdcf881f894a75cd9798ba173b425d4e62
Gerrit-Change-Number: 29470
Gerrit-PatchSet: 7
Gerrit-Owner: Frans Hendriks <fhendriks at eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks at eltan.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Comment-Date: Mon, 26 Nov 2018 08:14:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181126/4250865d/attachment.html>


More information about the coreboot-gerrit mailing list