[coreboot-gerrit] Change in ...coreboot[master]: Documentation/../../icelake_rvp: Add RVP coreboot development documen...

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29828 )

Change subject: Documentation/../../icelake_rvp: Add RVP coreboot development documentation
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Is this a WIP stub? It does not contain that much useful information.

https://review.coreboot.org/#/c/29828/1/Documentation/mainboard/intel/icelake_rvp.md 
File Documentation/mainboard/intel/icelake_rvp.md:

https://review.coreboot.org/#/c/29828/1/Documentation/mainboard/intel/icelake_rvp.md@3 
PS1, Line 3: This page describes how to run coreboot on the Intel icelake_rvp board.
I don't think this is accurate...

Please add what Kconfig options you need to configure (the defaults most certainly won't boot)



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29828
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If063cbd3436d9ee107945f425a31ba0009039a1d
Gerrit-Change-Number: 29828
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 26 Nov 2018 07:40:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181126/e0afab46/attachment.html>