[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/bd82x6x/early_usb.c: Fix formatting

Felix Held (Code Review) gerrit at coreboot.org
Fri Nov 23 22:54:45 CET 2018


Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29428 )

Change subject: sb/intel/bd82x6x/early_usb.c: Fix formatting
......................................................................

sb/intel/bd82x6x/early_usb.c: Fix formatting

Remove whitespace between the function name and open
parenthesis, and fix 81+ characters lines.
Unnecessary comment about 'include sandybridge.h'removed.

Change-Id: I0db1263ec11240003fe1f7080c758994fc0224d3
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
Reviewed-on: https://review.coreboot.org/c/29428
Reviewed-by: Felix Held <felix-coreboot at felixheld.de>
Reviewed-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M src/southbridge/intel/bd82x6x/early_usb.c
1 file changed, 13 insertions(+), 13 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Felix Held: Looks good to me, approved
  Jonathan Neuschäfer: Looks good to me, but someone else must approve



diff --git a/src/southbridge/intel/bd82x6x/early_usb.c b/src/southbridge/intel/bd82x6x/early_usb.c
index d4ff783..1044953 100644
--- a/src/southbridge/intel/bd82x6x/early_usb.c
+++ b/src/southbridge/intel/bd82x6x/early_usb.c
@@ -17,11 +17,10 @@
 #include <arch/io.h>
 #include <device/pci_ids.h>
 #include <device/pci_def.h>
-#include <northbridge/intel/sandybridge/sandybridge.h> /* For DEFAULT_RCBABASE.  */
+#include <northbridge/intel/sandybridge/sandybridge.h>
 #include "pch.h"
 
-void
-early_usb_init (const struct southbridge_usb_port *portmap)
+void early_usb_init(const struct southbridge_usb_port *portmap)
 {
 	u32 reg32;
 	const u32 rcba_dump[8] = {
@@ -35,41 +34,42 @@
 	/* Activate PMBAR.  */
 	pci_write_config32(PCI_DEV(0, 0x1f, 0), PMBASE, DEFAULT_PMBASE | 1);
 	pci_write_config32(PCI_DEV(0, 0x1f, 0), PMBASE + 4, 0);
-	pci_write_config8(PCI_DEV(0, 0x1f, 0), 0x44 /* ACPI_CNTL */, 0x80); /* Enable ACPI BAR */
+	/* Enable ACPI BAR */
+	pci_write_config8(PCI_DEV(0, 0x1f, 0), 0x44 /* ACPI_CNTL */, 0x80);
 
 	/* Unlock registers.  */
 	outw(inw(DEFAULT_PMBASE | UPRWC) | UPRWC_WR_EN,
 	     DEFAULT_PMBASE | UPRWC);
 
 	for (i = 0; i < 14; i++)
-		write32 (DEFAULT_RCBABASE + (0x3500 + 4 * i),
+		write32(DEFAULT_RCBABASE + (0x3500 + 4 * i),
 			 currents[portmap[i].current]);
 	for (i = 0; i < 10; i++)
-		write32 (DEFAULT_RCBABASE + (0x3538 + 4 * i), 0);
+		write32(DEFAULT_RCBABASE + (0x3538 + 4 * i), 0);
 
 	for (i = 0; i < 8; i++)
-		write32 (DEFAULT_RCBABASE + (0x3560 + 4 * i), rcba_dump[i]);
+		write32(DEFAULT_RCBABASE + (0x3560 + 4 * i), rcba_dump[i]);
 	for (i = 0; i < 8; i++)
-		write32 (DEFAULT_RCBABASE + (0x3580 + 4 * i), 0);
+		write32(DEFAULT_RCBABASE + (0x3580 + 4 * i), 0);
 	reg32 = 0;
 	for (i = 0; i < 14; i++)
 		if (!portmap[i].enabled)
 			reg32 |= (1 << i);
-	write32 (DEFAULT_RCBABASE + USBPDO, reg32);
+	write32(DEFAULT_RCBABASE + USBPDO, reg32);
 	reg32 = 0;
 	for (i = 0; i < 8; i++)
 		if (portmap[i].enabled && portmap[i].oc_pin >= 0)
 			reg32 |= (1 << (i + 8 * portmap[i].oc_pin));
-	write32 (DEFAULT_RCBABASE + USBOCM1, reg32);
+	write32(DEFAULT_RCBABASE + USBOCM1, reg32);
 	reg32 = 0;
 	for (i = 8; i < 14; i++)
 		if (portmap[i].enabled && portmap[i].oc_pin >= 4)
 			reg32 |= (1 << (i - 8 + 8 * (portmap[i].oc_pin - 4)));
-	write32 (DEFAULT_RCBABASE + USBOCM2, reg32);
+	write32(DEFAULT_RCBABASE + USBOCM2, reg32);
 	for (i = 0; i < 22; i++)
-		write32 (DEFAULT_RCBABASE + (0x35a8 + 4 * i), 0);
+		write32(DEFAULT_RCBABASE + (0x35a8 + 4 * i), 0);
 
-	pci_write_config32 (PCI_DEV (0, 0x14, 0), 0xe4, 0x00000000);
+	pci_write_config32(PCI_DEV(0, 0x14, 0), 0xe4, 0x00000000);
 
 	/* Relock registers.  */
 	outw(0, DEFAULT_PMBASE | UPRWC);

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29428
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0db1263ec11240003fe1f7080c758994fc0224d3
Gerrit-Change-Number: 29428
Gerrit-PatchSet: 5
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Hellsenberg <th3fanbus at gmail.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181123/fbcfb048/attachment.html>


More information about the coreboot-gerrit mailing list