[coreboot-gerrit] Change in ...coreboot[master]: Kconfig: Unify power-after-failure options

Nico Huber (Code Review) gerrit at coreboot.org
Fri Nov 23 10:02:58 CET 2018


Hello HAOUAS Elyes, Subrata Banik, Tristan Corrick, build bot (Jenkins), Patrick Georgi, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/29680

to look at the new patch set (#4).

Change subject: Kconfig: Unify power-after-failure options
......................................................................

Kconfig: Unify power-after-failure options

The newest and most useful incarnation was hiding in soc/intel/common/.
We move it into the Mainboard menu and extend it with various flags to
be selected to control the default and which options are visible. Also
add a new `int` config MAINBOARD_POWER_FAILURE_STATE that moves the
boolean to int conversion into Kconfig:
  0 - S5
  1 - S0
  2 - previous state

This patch focuses on the Kconfig code. The C code could be unified as
well, e.g. starting with a common enum and safe wrapper around the
get_option() call.

TEST=Did what-jenkins-does with and without this commit and compared
     binaries. Nothing changed for the default configurations.

Change-Id: I61259f864c8a8cfc7099cc2699059f972fa056c0
Signed-off-by: Nico Huber <nico.h at gmx.de>
---
M src/mainboard/Kconfig
M src/mainboard/asrock/h81m-hds/Kconfig
M src/mainboard/asus/kcma-d8/Kconfig
M src/mainboard/asus/kfsn4-dre/Kconfig
M src/mainboard/asus/kgpe-d16/Kconfig
M src/mainboard/msi/ms9652_fam10/Kconfig
M src/mainboard/samsung/lumpy/Kconfig
M src/mainboard/samsung/stumpy/Kconfig
M src/soc/intel/broadwell/Kconfig
M src/soc/intel/broadwell/lpc.c
M src/soc/intel/broadwell/smihandler.c
M src/soc/intel/common/block/include/intelblocks/pmclib.h
M src/soc/intel/common/block/pmc/Kconfig
M src/soc/intel/common/block/pmc/pmclib.c
M src/southbridge/amd/agesa/hudson/sm.c
M src/southbridge/amd/amd8111/Kconfig
M src/southbridge/amd/amd8111/acpi.c
M src/southbridge/amd/pi/hudson/sm.c
M src/southbridge/amd/sb700/Kconfig
M src/southbridge/amd/sb700/sm.c
M src/southbridge/amd/sb800/sm.c
M src/southbridge/intel/bd82x6x/lpc.c
M src/southbridge/intel/common/Kconfig
M src/southbridge/intel/common/pmutil.h
M src/southbridge/intel/common/smihandler.c
M src/southbridge/intel/fsp_rangeley/soc.h
M src/southbridge/intel/i82801dx/Kconfig
M src/southbridge/intel/i82801dx/i82801dx.h
M src/southbridge/intel/i82801dx/lpc.c
M src/southbridge/intel/i82801dx/smihandler.c
M src/southbridge/intel/i82801gx/Kconfig
M src/southbridge/intel/i82801gx/i82801gx.h
M src/southbridge/intel/i82801gx/lpc.c
M src/southbridge/intel/i82801gx/smihandler.c
M src/southbridge/intel/i82801ix/i82801ix.h
M src/southbridge/intel/i82801ix/lpc.c
M src/southbridge/intel/i82801jx/Kconfig
M src/southbridge/intel/i82801jx/i82801jx.h
M src/southbridge/intel/i82801jx/lpc.c
M src/southbridge/intel/ibexpeak/Kconfig
M src/southbridge/intel/ibexpeak/lpc.c
M src/southbridge/intel/ibexpeak/pch.h
M src/southbridge/intel/ibexpeak/smihandler.c
M src/southbridge/intel/lynxpoint/Kconfig
M src/southbridge/intel/lynxpoint/lpc.c
M src/southbridge/intel/lynxpoint/pch.h
M src/southbridge/intel/lynxpoint/smihandler.c
M src/southbridge/nvidia/ck804/Kconfig
M src/southbridge/nvidia/ck804/lpc.c
M src/southbridge/nvidia/mcp55/Kconfig
M src/southbridge/nvidia/mcp55/lpc.c
M src/superio/nuvoton/nct5572d/Kconfig
M src/superio/nuvoton/nct5572d/superio.c
M src/superio/winbond/w83667hg-a/Kconfig
M src/superio/winbond/w83667hg-a/superio.c
55 files changed, 121 insertions(+), 164 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/29680/4
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29680
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I61259f864c8a8cfc7099cc2699059f972fa056c0
Gerrit-Change-Number: 29680
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Hellsenberg <th3fanbus at gmail.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181123/a881f6a8/attachment.html>


More information about the coreboot-gerrit mailing list