[coreboot-gerrit] Change in ...coreboot[master]: cpu/x86/Kconfig.debug: Remove weird dependencies and comments

Nico Huber (Code Review) gerrit at coreboot.org
Thu Nov 22 19:08:48 CET 2018


Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29802


Change subject: cpu/x86/Kconfig.debug: Remove weird dependencies and comments
......................................................................

cpu/x86/Kconfig.debug: Remove weird dependencies and comments

No need to hide prompts, it's a user choice anyway, they should know.
The help texts were just rephrasing the prompts or stating the obvious.

Change-Id: I5694a88f2da57af2a20357c4e22c7c648053cc26
Signed-off-by: Nico Huber <nico.h at gmx.de>
---
M src/cpu/x86/Kconfig.debug
1 file changed, 1 insertion(+), 14 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/29802/1

diff --git a/src/cpu/x86/Kconfig.debug b/src/cpu/x86/Kconfig.debug
index c5e21ef..1c615f9 100644
--- a/src/cpu/x86/Kconfig.debug
+++ b/src/cpu/x86/Kconfig.debug
@@ -2,14 +2,8 @@
 	bool
 
 config DEBUG_CAR
-	bool
+	bool "Output verbose Cache-as-RAM debug messages"
 	depends on HAVE_DEBUG_CAR
-	# Only visible if debug level is DEBUG (7) or SPEW (8) as it does
-	# additional printk(BIOS_DEBUG, ...) calls.
-	prompt "Output verbose Cache-as-RAM debug messages" \
-		if DEFAULT_CONSOLE_LOGLEVEL_7 || DEFAULT_CONSOLE_LOGLEVEL_8
-	help
-	  This option enables additional CAR related debug messages.
 
 config HAVE_DISPLAY_MTRRS
 	bool
@@ -21,10 +15,3 @@
 config DEBUG_SMM_RELOCATION
 	bool "Debug SMM relocation code"
 	depends on HAVE_SMI_HANDLER
-	help
-	  This option enables additional SMM handler relocation related
-	  debug messages.
-
-	  Note: This option will increase the size of the coreboot image.
-
-	  If unsure, say N.

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29802
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5694a88f2da57af2a20357c4e22c7c648053cc26
Gerrit-Change-Number: 29802
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181122/1f072684/attachment-0001.html>


More information about the coreboot-gerrit mailing list