[coreboot-gerrit] Change in ...coreboot[master]: riscv: fix bug of sifive-gpt.py
Patrick Georgi (Code Review)
gerrit at coreboot.org
Thu Nov 22 15:48:45 CET 2018
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29767 )
Change subject: riscv: fix bug of sifive-gpt.py
......................................................................
riscv: fix bug of sifive-gpt.py
The GPT version must be "00 00 01 00" and the little endian should be
represented as 0x10000.
Please refer to: https://en.wikipedia.org/wiki/GUID_Partition_Table
Change-Id: Ib025197fc96f32823e687a89de0cee51c952b031
Signed-off-by: Xiang Wang <wxjstz at 126.com>
Reviewed-on: https://review.coreboot.org/c/29767
Reviewed-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M util/riscv/sifive-gpt.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Jonathan Neuschäfer: Looks good to me, approved
diff --git a/util/riscv/sifive-gpt.py b/util/riscv/sifive-gpt.py
index 7f522d9..f1e4fa8 100755
--- a/util/riscv/sifive-gpt.py
+++ b/util/riscv/sifive-gpt.py
@@ -88,7 +88,7 @@
def pack_with_crc(self, crc):
header_size = 92
header = struct.pack('<8sIIIIQQQQ16sQIII',
- b'EFI PART', 0x100, header_size, crc, 0,
+ b'EFI PART', 0x10000, header_size, crc, 0,
self.current_lba, self.backup_lba, self.first_usable_lba,
self.last_usable_lba, self.uniq.get_bytes(),
self.part_entries_lba, self.part_entries_number,
--
To view, visit https://review.coreboot.org/c/coreboot/+/29767
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib025197fc96f32823e687a89de0cee51c952b031
Gerrit-Change-Number: 29767
Gerrit-PatchSet: 4
Gerrit-Owner: Xiang Wang <wxjstz at 126.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Philipp Hug <philipp at hug.cx>
Gerrit-Reviewer: Shawn Chang <citypw at gmail.com>
Gerrit-Reviewer: Xiang Wang <wxjstz at 126.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181122/7cc19e92/attachment.html>
More information about the coreboot-gerrit
mailing list