[coreboot-gerrit] Change in ...coreboot[master]: mb/google/fizz/variants/karma: Disable SD controller and update GPIO
Zhuohao Lee (Code Review)
gerrit at coreboot.org
Thu Nov 22 10:48:07 CET 2018
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29765 )
Change subject: mb/google/fizz/variants/karma: Disable SD controller and update GPIO
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/29765/3/src/mainboard/google/fizz/variants/baseboard/devicetree.cb
File src/mainboard/google/fizz/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/29765/3/src/mainboard/google/fizz/variants/baseboard/devicetree.cb@a258
PS3, Line 258:
Do we need to move this to fizz/overridetree.cb?
https://review.coreboot.org/#/c/29765/3/src/mainboard/google/fizz/variants/baseboard/devicetree.cb@a268
PS3, Line 268:
Same here?
--
To view, visit https://review.coreboot.org/c/coreboot/+/29765
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8015fe35a4ff79469b5781942f588c3e1b88b751
Gerrit-Change-Number: 29765
Gerrit-PatchSet: 3
Gerrit-Owner: David Wu <david_wu at quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu at quanta.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 22 Nov 2018 09:48:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181122/42e009cb/attachment.html>
More information about the coreboot-gerrit
mailing list