[coreboot-gerrit] Change in ...coreboot[master]: mb/google/dragonegg: Add initial mainboard code support

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29749 )

Change subject: mb/google/dragonegg: Add initial mainboard code support
......................................................................


Patch Set 9:

> Patch Set 9:
> 
> > Patch Set 9:
> > 
> > > > > Please add Documentation for that board.
> >  > > > For example:
> >  > > > How to flash, required BLOBs, pictures if possible, everything
> >  > > that
> >  > > > is useful for coreboot development.
> >  > >
> >  > > I will let Shelley to answer this question. As this is early ICL
> >  > > silicon, i'm not sure about board availability to able to build
> >  > at
> >  > > externally.
> >  > 
> >  > That would be wonderful to have it in the Documentation :-).
> > 
> > Patrick, do you have any sample documentation that can be referred here
> 
> Patrick,
> 
> Flashing is the same as other Intel boards:
> 
> $ dut-control spi2_vref:pp3300 spi2_buf_en:on spi2_buf_on_flex_en:on warm_reset:on
> $ sudo flashrom -n -p ft2232_spi:type=servo-v2 -w <bios_image>
> $ dut-control spi2_vref:off spi2_buf_en:off spi2_buf_on_flex_en:off warm_reset:off
> 
> Sorry, I do not have the pointers to the blobs as they are in the Intel VIP site and I can't post photos of the board as it is a early development board.

How to write documentation can be found here:
https://doc.coreboot.org/getting_started/writing_documentation.html

Sample documentation can be found in git, here:
Documentation/mainboard/*/*.md

All those facts mentioned should go into the documentation.
Also:
Will it be available for purchase ?
Will it be available as reference platform for OEMs ?
Is it an internal project only ?
If the blobs aren't available, the code wont work at all, that should be mentioned in the Documentation and fixed once the BLOBs are available.
Are there schematics or other documents you can reference ?


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29749
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2cc269cb0050bf5b031f48cfe114485c55ab8fa9
Gerrit-Change-Number: 29749
Gerrit-PatchSet: 9
Gerrit-Owner: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 22 Nov 2018 08:01:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181122/8a410deb/attachment.html>