[coreboot-gerrit] Change in ...coreboot[master]: src/soc/intel/braswellsouthcluster.c: Replace fixed values by defines
Frans Hendriks (Code Review)
gerrit at coreboot.org
Thu Nov 22 07:58:59 CET 2018
Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29788
Change subject: src/soc/intel/braswellsouthcluster.c: Replace fixed values by defines
......................................................................
src/soc/intel/braswellsouthcluster.c: Replace fixed values by defines
The GPIO and ACPI base sizes have defines, but they are not used.
Use GPIO_BASE_SIZE and ACPI_BASE_SIZE.
BUG=N/A
TEST=Intel CherryHill CRB
Change-Id: I348eda57ab9dc0bd45f8dc9ab0e7c47c462102fe
Signed-off-by: Frans Hendriks <fhendriks at eltan.com>
---
M src/soc/intel/braswell/southcluster.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/29788/1
diff --git a/src/soc/intel/braswell/southcluster.c b/src/soc/intel/braswell/southcluster.c
index ae4b8c5..0c88004 100644
--- a/src/soc/intel/braswell/southcluster.c
+++ b/src/soc/intel/braswell/southcluster.c
@@ -126,10 +126,10 @@
res->flags = IORESOURCE_IO | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
/* GPIO */
- sc_add_io_resource(dev, GPIO_BASE_ADDRESS, 256, GBASE);
+ sc_add_io_resource(dev, GPIO_BASE_ADDRESS, GPIO_BASE_SIZE, GBASE);
/* ACPI */
- sc_add_io_resource(dev, ACPI_BASE_ADDRESS, 128, ABASE);
+ sc_add_io_resource(dev, ACPI_BASE_ADDRESS, ACPI_BASE_SIZE, ABASE);
}
static void sc_read_resources(struct device *dev)
--
To view, visit https://review.coreboot.org/c/coreboot/+/29788
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I348eda57ab9dc0bd45f8dc9ab0e7c47c462102fe
Gerrit-Change-Number: 29788
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks <fhendriks at eltan.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181122/6fb3c172/attachment.html>
More information about the coreboot-gerrit
mailing list