[coreboot-gerrit] Change in ...coreboot[master]: SMI: Introduce CONFIG_SOC_INTEL_BYPASS_PORT_B2_SMI

[Jenny Tc (Code Review)]

Jenny Tc has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29775 )

Change subject: SMI: Introduce CONFIG_SOC_INTEL_BYPASS_PORT_B2_SMI
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/29775/1/src/ec/google/chromeec/smihandler.c 
File src/ec/google/chromeec/smihandler.c:

https://review.coreboot.org/#/c/29775/1/src/ec/google/chromeec/smihandler.c@102 
PS1, Line 102: #if IS_ENABLED(CONFIG_SOC_INTEL_BYPASS_PORT_B2_SMI)
> one alternative way to achieve this is https://review.coreboot. […]
Okay.. What about using CONFIG_REDUCED_SMI just to remove the function definition in order to reduce the image size?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29775
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43ca93972fa4d870632707cb9a9e74ab80cbd5d5
Gerrit-Change-Number: 29775
Gerrit-PatchSet: 1
Gerrit-Owner: Jenny Tc <jenny.tc at intel.com>
Gerrit-Reviewer: Jenny Tc <jenny.tc at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-CC: Dhaval Sharma <dhaval.v.sharma at intel.corp-partner.google.com>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Thu, 22 Nov 2018 04:42:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dhaval Sharma <dhaval.v.sharma at intel.corp-partner.google.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181122/192243a5/attachment.html>