[coreboot-gerrit] Change in ...coreboot[master]: SMI: Introduce CONFIG_SOC_INTEL_BYPASS_PORT_B2_SMI

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29775 )

Change subject: SMI: Introduce CONFIG_SOC_INTEL_BYPASS_PORT_B2_SMI
......................................................................


Patch Set 1:

(1 comment)

If the Kconfig option is used in ec/google/chromeec, it should
also be defined there (and named accordingly).

https://review.coreboot.org/#/c/29775/1/src/ec/google/chromeec/smihandler.c 
File src/ec/google/chromeec/smihandler.c:

https://review.coreboot.org/#/c/29775/1/src/ec/google/chromeec/smihandler.c@a103 
PS1, Line 103: 
A nicer way to code it in C would be to put something like this here:

    if (IS_ENABLED(CONFIG_SOC_INTEL_BYPASS_PORT_B2_SMI))
            return;

The compiler would take care of the dead code but it would still be compile
tested (no matter the config state).



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29775
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43ca93972fa4d870632707cb9a9e74ab80cbd5d5
Gerrit-Change-Number: 29775
Gerrit-PatchSet: 1
Gerrit-Owner: Jenny Tc <jenny.tc at intel.com>
Gerrit-Reviewer: Jenny Tc <jenny.tc at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Wed, 21 Nov 2018 23:03:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181121/e3ec08ca/attachment.html>