[coreboot-gerrit] Change in ...coreboot[master]: grunt: Default SPK_PA_EN to LOW

Raul Rangel (Code Review) gerrit at coreboot.org
Wed Nov 21 23:28:16 CET 2018


Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29783


Change subject: grunt: Default SPK_PA_EN to LOW
......................................................................

grunt: Default SPK_PA_EN to LOW

We need to default this to low so the speakers don't activate in S3.

BUG=b:118248953
TEST=Used a scope to look at the line and made sure depthcharge still
beeps.

Change-Id: I70d2f4a3261d212b62e784fa7414e45b1d575612
Signed-off-by: Raul E Rangel <rrangel at chromium.org>
---
M src/mainboard/google/kahlee/variants/baseboard/gpio.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/29783/1

diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c
index 95064bc..2d48efe 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c
+++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c
@@ -207,7 +207,7 @@
 	PAD_NF(GPIO_118, SPI_CS1_L, PULL_NONE),
 
 	/* GPIO_119 - SPK_PA_EN */
-	PAD_GPO(GPIO_119, HIGH),
+	PAD_GPO(GPIO_119, LOW),
 
 	/* GPIO_126 - DMIC_CLK2_EN */
 	PAD_GPO(GPIO_126, HIGH),

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29783
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70d2f4a3261d212b62e784fa7414e45b1d575612
Gerrit-Change-Number: 29783
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181121/116fe6a5/attachment.html>


More information about the coreboot-gerrit mailing list