[coreboot-gerrit] Change in ...coreboot[master]: util/scripts/maintainers.go: file: queries are more stable with quotes

Patrick Georgi (Code Review) gerrit at coreboot.org
Wed Nov 21 22:08:21 CET 2018


Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29781


Change subject: util/scripts/maintainers.go: file: queries are more stable with quotes
......................................................................

util/scripts/maintainers.go: file: queries are more stable with quotes

The gerrit docs aren't very explicit about it, but file:"^foo$" is more
robust than file:^foo$.

Change-Id: I16c7d972d365cd04ca5fbb78012ad4eaad667be6
Signed-off-by: Patrick Georgi <pgeorgi at google.com>
---
M util/scripts/maintainers.go
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/29781/1

diff --git a/util/scripts/maintainers.go b/util/scripts/maintainers.go
index 76306c8..31a720c 100644
--- a/util/scripts/maintainers.go
+++ b/util/scripts/maintainers.go
@@ -278,7 +278,7 @@
 		}
 		fmt.Println("#", subsystem.name)
 		for _, path := range subsystem.paths {
-			fmt.Println("[filter \"file:" + path_to_regexstr(path) + "\"]")
+			fmt.Println("[filter \"file:\\\"" + path_to_regexstr(path) + "\\\"\"]")
 			for _, maint := range subsystem.maintainer {
 				fmt.Println("  reviewer =", extract_maintainer(maint))
 			}

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29781
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16c7d972d365cd04ca5fbb78012ad4eaad667be6
Gerrit-Change-Number: 29781
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181121/28537527/attachment-0001.html>


More information about the coreboot-gerrit mailing list