[coreboot-gerrit] Change in ...coreboot[master]: mb/google/octopus: Configure all debug header lines as NC

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29780 )

Change subject: mb/google/octopus: Configure all debug header lines as NC
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/29780/1/src/mainboard/google/octopus/variants/baseboard/gpio.c 
File src/mainboard/google/octopus/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/29780/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@52 
PS1, Line 52: 	PAD_NC(GPIO_24,UP_20K), /* TRACE_1_DATA6_VNN -- debug header NC */
space required after that ',' (ctx:VxV)


https://review.coreboot.org/#/c/29780/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@53 
PS1, Line 53: 	PAD_NC(GPIO_25,UP_20K), /* TRACE_1_DATA7_VNN -- debug header NC */
space required after that ',' (ctx:VxV)



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29780
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3ffdbf6ad9b1682deaada91b5c225b4c8dd035b
Gerrit-Change-Number: 29780
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 21 Nov 2018 20:07:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181121/6788901f/attachment.html>