[coreboot-gerrit] Change in ...coreboot[master]: mb/google/poppy/variants/nami: Enable g2touch touchscreen device
Furquan Shaikh (Code Review)
gerrit at coreboot.org
Wed Nov 21 19:49:22 CET 2018
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29768 )
Change subject: mb/google/poppy/variants/nami: Enable g2touch touchscreen device
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29768/1/src/mainboard/google/poppy/variants/nami/devicetree.cb
File src/mainboard/google/poppy/variants/nami/devicetree.cb:
https://review.coreboot.org/#/c/29768/1/src/mainboard/google/poppy/variants/nami/devicetree.cb@350
PS1, Line 350: _
I don't think using '_' is valid. HID needs to be either uppercase letter (A-Z) or numeral (0-9).
--
To view, visit https://review.coreboot.org/c/coreboot/+/29768
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26e16b7e118121b3dd9a88c76d04898b97753df0
Gerrit-Change-Number: 29768
Gerrit-PatchSet: 1
Gerrit-Owner: Crystal Lin <crystal_lin at compal.corp-partner.google.com>
Gerrit-Reviewer: Crystal Lin <crystal_lin at compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 21 Nov 2018 18:49:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181121/e2fb49f6/attachment.html>
More information about the coreboot-gerrit
mailing list