[coreboot-gerrit] Change in ...coreboot[master]: mb/google/fizz/variants/karma: Enable touchscreen wakeup

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29769 )

Change subject: mb/google/fizz/variants/karma: Enable touchscreen wakeup
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/29769/1/src/mainboard/google/fizz/variants/karma/gpio.c 
File src/mainboard/google/fizz/variants/karma/gpio.c:

https://review.coreboot.org/#/c/29769/1/src/mainboard/google/fizz/variants/karma/gpio.c@54 
PS1, Line 54: PAD_CFG_GPO(GPP_B4, 1, DEEP), /* PCH_TS_EN */
I haven't looked at the schematics or the part data sheet. How does this enable work? Does it need to be set always or just before entering suspend? Does it need to be disabled when entering deeper states like S5? You can email me the datasheet if you want.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29769
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0c9493dec367c7813047c7994cc83537aaef141
Gerrit-Change-Number: 29769
Gerrit-PatchSet: 1
Gerrit-Owner: David Wu <david_wu at quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu at quanta.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 21 Nov 2018 18:31:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181121/3ccde159/attachment.html>