[coreboot-gerrit] Change in ...coreboot[master]: intelblocks/cpu: Add function to set CPU clock to minimum value

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29771 )

Change subject: intelblocks/cpu: Add function to set CPU clock to minimum value
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/29771/3/src/soc/intel/common/block/cpu/cpulib.c 
File src/soc/intel/common/block/cpu/cpulib.c:

https://review.coreboot.org/#/c/29771/3/src/soc/intel/common/block/cpu/cpulib.c@159 
PS3, Line 159: ((perf_ctl.lo >> 8) & 0xff)
> this should be `min_ratio`?
Yes Nico, you are so right. I totally overseen it. Thanks for catching, will update.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29771
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I817095b13ab8cbaab82f25c72947b00ee854d549
Gerrit-Change-Number: 29771
Gerrit-PatchSet: 3
Gerrit-Owner: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at gmail.com>
Gerrit-Reviewer: Huang Jin <huang.jin at intel.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 21 Nov 2018 18:11:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h at gmx.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181121/4f5154ac/attachment.html>