[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/skylake: Use real common code for VMX init

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29682 )

Change subject: soc/intel/skylake: Use real common code for VMX init
......................................................................


Patch Set 3:

while there is no issue with using the common VMX implementation (tested on Librem 13v2), selecting the VMX lock function (which is selected by default) will prevent the use of SGX on supported platforms due to both being controlled by the IA32_FEATURE_CONTROL msr. 

The locking of IA32_FEATURE_CONTROL should really be broken out into a separate function and performed after both VMX and SGX configuration if enabled, preferably as an antecedent to this commit.


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29682
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea598cf74ba542a650433719f29cb5c9df700c0f
Gerrit-Change-Number: 29682
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 21 Nov 2018 17:01:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181121/b1ad5165/attachment.html>