[coreboot-gerrit] Change in ...coreboot[master]: util/cbfstool: Fix GCC error due to a shadowed declaration

Joel Kitching (Code Review) gerrit at coreboot.org
Wed Nov 21 17:50:04 CET 2018


Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29776 )

Change subject: util/cbfstool: Fix GCC error due to a shadowed declaration
......................................................................


Patch Set 2: Code-Review+2

Thanks for catching this, Werner!  Although I do wonder, is buffer_size the best name for a function?


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29776
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifae3a17152f2f9852d29a4ac038f7e5a75a41614
Gerrit-Change-Number: 29776
Gerrit-PatchSet: 2
Gerrit-Owner: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: Joel Kitching <kitching at google.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 21 Nov 2018 16:50:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181121/493ccbde/attachment.html>


More information about the coreboot-gerrit mailing list