[coreboot-gerrit] Change in ...coreboot[master]: Kconfig: Unify power-after-failure options

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29680 )

Change subject: Kconfig: Unify power-after-failure options
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/29680/3/src/soc/intel/common/block/pmc/pmclib.c 
File src/soc/intel/common/block/pmc/pmclib.c:

https://review.coreboot.org/#/c/29680/3/src/soc/intel/common/block/pmc/pmclib.c@590 
PS3, Line 590: 	return CONFIG_MAINBOARD_POWER_FAILURE_STATE;
> we are ignoring "Keep Previous State" options ?
`config MAINBOARD_POWER_FAILURE_STATE` is an `int` taking either 0, 1 or 2.
Just what this function used to return.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29680
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I61259f864c8a8cfc7099cc2699059f972fa056c0
Gerrit-Change-Number: 29680
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus at gmail.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 15:02:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subrata.banik at intel.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181121/9998dc94/attachment.html>