[coreboot-gerrit] Change in ...coreboot[master]: intelblocks/cpu: Add function to enable maximum efficiency

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29771 )

Change subject: intelblocks/cpu: Add function to enable maximum efficiency
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> Does Intel call it "maximum efficiency" in their documentation? What
> you describe would lower power not energy, which confuses me. Efficient
> should be to save energy, i.e. the best performance per power.

If you have a look at the MSR description (the big Intel software developer manual), you will find the following text for the bits in question:

Maximum Efficiency Ratio (R/O) 
The is the minimum ratio (maximum efficiency) that the processor 
can operates, in units of 100MHz.

This is the reason for the naming.


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29771
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I817095b13ab8cbaab82f25c72947b00ee854d549
Gerrit-Change-Number: 29771
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at gmail.com>
Gerrit-Reviewer: Huang Jin <huang.jin at intel.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Wed, 21 Nov 2018 13:52:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181121/12f36dda/attachment.html>