[coreboot-gerrit] Change in ...coreboot[master]: nb/intel/haswell: Move MMCONF_BASE_ADDRESS to northbridge Kconfig

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/28603 )

Change subject: nb/intel/haswell: Move MMCONF_BASE_ADDRESS to northbridge Kconfig
......................................................................

nb/intel/haswell: Move MMCONF_BASE_ADDRESS to northbridge Kconfig

Change-Id: I44f27405fc8ccbe54c7d19b70327da866390a156
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
Reviewed-on: https://review.coreboot.org/c/28603
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Arthur Heymans <arthur at aheymans.xyz>
Reviewed-by: Tristan Corrick <tristan at corrick.kiwi>
---
M src/mainboard/asrock/h81m-hds/Kconfig
M src/mainboard/google/beltino/Kconfig
M src/mainboard/google/slippy/Kconfig
M src/mainboard/intel/baskingridge/Kconfig
M src/northbridge/intel/haswell/Kconfig
5 files changed, 4 insertions(+), 16 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved
  Tristan Corrick: Looks good to me, but someone else must approve



diff --git a/src/mainboard/asrock/h81m-hds/Kconfig b/src/mainboard/asrock/h81m-hds/Kconfig
index f93fcdb..00edd1c 100644
--- a/src/mainboard/asrock/h81m-hds/Kconfig
+++ b/src/mainboard/asrock/h81m-hds/Kconfig
@@ -74,10 +74,6 @@
 	int
 	default 8
 
-config MMCONF_BASE_ADDRESS
-	hex
-	default 0xf0000000
-
 #
 # Since this is a desktop board, the assumption is made that most users
 # would want CMOS configuration enabled by default.
diff --git a/src/mainboard/google/beltino/Kconfig b/src/mainboard/google/beltino/Kconfig
index aaec9f7..2f51461 100644
--- a/src/mainboard/google/beltino/Kconfig
+++ b/src/mainboard/google/beltino/Kconfig
@@ -53,10 +53,6 @@
 	default "X86 TRICKY TEST 4487" if BOARD_GOOGLE_TRICKY
 	default "X86 ZAKO TEST 8602" if BOARD_GOOGLE_ZAKO
 
-config MMCONF_BASE_ADDRESS
-	hex
-	default 0xf0000000
-
 config MAX_CPUS
 	int
 	default 8
diff --git a/src/mainboard/google/slippy/Kconfig b/src/mainboard/google/slippy/Kconfig
index 738735e..fe7e5b3 100644
--- a/src/mainboard/google/slippy/Kconfig
+++ b/src/mainboard/google/slippy/Kconfig
@@ -58,10 +58,6 @@
 	string
 	default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"
 
-config MMCONF_BASE_ADDRESS
-	hex
-	default 0xf0000000
-
 config MAX_CPUS
 	int
 	default 8
diff --git a/src/mainboard/intel/baskingridge/Kconfig b/src/mainboard/intel/baskingridge/Kconfig
index 1fd07c2..2119d47de 100644
--- a/src/mainboard/intel/baskingridge/Kconfig
+++ b/src/mainboard/intel/baskingridge/Kconfig
@@ -25,10 +25,6 @@
 	string
 	default "BASKING RIDGE"
 
-config MMCONF_BASE_ADDRESS
-	hex
-	default 0xf0000000
-
 config MAX_CPUS
 	int
 	default 16
diff --git a/src/northbridge/intel/haswell/Kconfig b/src/northbridge/intel/haswell/Kconfig
index f9c68f3..0362ffe 100644
--- a/src/northbridge/intel/haswell/Kconfig
+++ b/src/northbridge/intel/haswell/Kconfig
@@ -36,6 +36,10 @@
 	string
 	default "8086,0166"
 
+config MMCONF_BASE_ADDRESS
+	hex
+	default 0xf0000000
+
 config CACHE_MRC_SIZE_KB
 	int
 	default 512

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/28603
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44f27405fc8ccbe54c7d19b70327da866390a156
Gerrit-Change-Number: 28603
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181121/5e305028/attachment.html>