[coreboot-gerrit] Change in ...coreboot[master]: mb/intel/icelake_rvp: Add ICL U and Y DIMM configuration

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29770 )

Change subject: mb/intel/icelake_rvp: Add ICL U and Y DIMM configuration
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/29770/1/src/mainboard/intel/icelake_rvp/Makefile.inc 
File src/mainboard/intel/icelake_rvp/Makefile.inc:

https://review.coreboot.org/#/c/29770/1/src/mainboard/intel/icelake_rvp/Makefile.inc@24 
PS1, Line 24: 
extra line


https://review.coreboot.org/#/c/29770/1/src/mainboard/intel/icelake_rvp/board_id.c 
File src/mainboard/intel/icelake_rvp/board_id.c:

https://review.coreboot.org/#/c/29770/1/src/mainboard/intel/icelake_rvp/board_id.c@31 
PS1, Line 31: /*
            :  * Get Board ID via EC I/O port write/read
            :  */
make single line comment



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29770
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id596a3c85b13559b3002dcadfee9c945256e28e7
Gerrit-Change-Number: 29770
Gerrit-PatchSet: 1
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 11:14:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181121/00b84f64/attachment.html>