[coreboot-gerrit] Change in ...coreboot[master]: src/soc/intel/braswell/include/soc/irq.h: Set bit 7 of PIRQ register ...

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29393 )

Change subject: src/soc/intel/braswell/include/soc/irq.h: Set bit 7 of PIRQ register to disable
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/29393/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/29393/3//COMMIT_MSG@7 
PS3, Line 7: src/soc/intel/braswell/include/soc/irq.h: Set bit 7 of PIRQ register to disable
That's not what's done in the commit.
Rephrase to "fix MACRO ..." ?

Same below, you don't touch any register.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29393
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18706f12e7c2293e948eb10818393f0d1870f514
Gerrit-Change-Number: 29393
Gerrit-PatchSet: 3
Gerrit-Owner: Frans Hendriks <fhendriks at eltan.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 21 Nov 2018 09:20:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181121/ebabdc8f/attachment.html>