[coreboot-gerrit] Change in ...coreboot[master]: mb/google/fizz/variants/karma: Disable SD controller and update GPIO

[David Wu (Code Review)]

David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29765 )

Change subject: mb/google/fizz/variants/karma: Disable SD controller and update GPIO
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/29765/2/src/mainboard/google/fizz/variants/karma/overridetree.cb 
File src/mainboard/google/fizz/variants/karma/overridetree.cb:

https://review.coreboot.org/#/c/29765/2/src/mainboard/google/fizz/variants/karma/overridetree.cb@24 
PS2, Line 24: 2.3
> Devices 2.3, 2.9, 3.3 in baseboard/devicetree should be moved to fizz/overridetree. […]
I can't see device 2.9 in baseboard/devicetree.cb, so I will move device 2.3 and 3.3 to fizz/overridetree.cb. Thanks.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29765
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8015fe35a4ff79469b5781942f588c3e1b88b751
Gerrit-Change-Number: 29765
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu <david_wu at quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu at quanta.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 21 Nov 2018 07:29:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan at google.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181121/a7081809/attachment.html>