[coreboot-gerrit] Change in ...coreboot[master]: cpu/x86/Kconfig.debug: Move more options here

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29751 )

Change subject: cpu/x86/Kconfig.debug: Move more options here
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/29751/1/src/cpu/x86/Kconfig.debug 
File src/cpu/x86/Kconfig.debug:

https://review.coreboot.org/#/c/29751/1/src/cpu/x86/Kconfig.debug@10 
PS1, Line 10: 		if DEFAULT_CONSOLE_LOGLEVEL_7 || DEFAULT_CONSOLE_LOGLEVEL_8
nit: I'm okay with leaving it as it is, but in general this doesn't sound like the right thing to do. In some configurations there are ways to change loglevel at runtime, so we probably shouldn't presume here.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29751
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3bb8e759fc6a4871d30fccff47babfb7a291b45c
Gerrit-Change-Number: 29751
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 21 Nov 2018 01:14:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181121/cf2c64d5/attachment.html>