[coreboot-gerrit] Change in ...coreboot[master]: mb/google/dragonegg: Patch for Audio Enabling

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29753 )

Change subject: mb/google/dragonegg: Patch for Audio Enabling
......................................................................


Patch Set 1:

(4 comments)

https://review.coreboot.org/#/c/29753/1/src/mainboard/google/dragonegg/variants/baseboard/gpio.c 
File src/mainboard/google/dragonegg/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/29753/1/src/mainboard/google/dragonegg/variants/baseboard/gpio.c@53 
PS1, Line 53: /* SPKR_RST_L */ 	PAD_CFG_GPO(GPP_F19, 1, DEEP),
please, no space before tabs


https://review.coreboot.org/#/c/29753/1/src/mainboard/google/dragonegg/variants/baseboard/gpio.c@62 
PS1, Line 62: /* I2S0_SCLK */ 		PAD_CFG_GPO(GPP_R0, 1, DEEP),
please, no space before tabs


https://review.coreboot.org/#/c/29753/1/src/mainboard/google/dragonegg/variants/baseboard/gpio.c@63 
PS1, Line 63: /* I2S0_SFRM */ 		PAD_CFG_GPO(GPP_R1, 1, DEEP),
please, no space before tabs


https://review.coreboot.org/#/c/29753/1/src/mainboard/google/dragonegg/variants/baseboard/gpio.c@64 
PS1, Line 64: /* I2S0_TXD */ 		PAD_CFG_GPO(GPP_R2, 1, DEEP),
please, no space before tabs



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29753
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia4843185dd79a35476c4f0fc0666ebaf3773db4c
Gerrit-Change-Number: 29753
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 20 Nov 2018 22:51:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181120/b5fbf876/attachment.html>