[coreboot-gerrit] Change in ...coreboot[master]: mb/google/dragonegg: Add initial mainboard code support

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29749 )

Change subject: mb/google/dragonegg: Add initial mainboard code support
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/29749/1/src/mainboard/google/dragonegg/variants/baseboard/gpio.c 
File src/mainboard/google/dragonegg/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/29749/1/src/mainboard/google/dragonegg/variants/baseboard/gpio.c@34 
PS1, Line 34: /* M2_SHUTDOWN+L */ 		PAD_CFG_GPO(GPP_C12, 1, PLTRST),
please, no space before tabs


https://review.coreboot.org/#/c/29749/1/src/mainboard/google/dragonegg/variants/baseboard/gpio.c@47 
PS1, Line 47: /* CNV_CLKREQ0 */ 		PAD_CFG_NF(GPP_F5, DN_20K, PWROK, NF2),
please, no space before tabs


https://review.coreboot.org/#/c/29749/1/src/mainboard/google/dragonegg/variants/baseboard/memory.c 
File src/mainboard/google/dragonegg/variants/baseboard/memory.c:

https://review.coreboot.org/#/c/29749/1/src/mainboard/google/dragonegg/variants/baseboard/memory.c@68 
PS1, Line 68: 	else {
else should follow close brace '}'



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29749
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2cc269cb0050bf5b031f48cfe114485c55ab8fa9
Gerrit-Change-Number: 29749
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 20 Nov 2018 22:44:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181120/4f5a5499/attachment.html>