[coreboot-gerrit] Change in ...coreboot[master]: include/spd_ddr2: Remove common SPD byte 2

Elyes HAOUAS (Code Review) gerrit at coreboot.org
Tue Nov 20 12:44:20 CET 2018


Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29725


Change subject: include/spd_ddr2: Remove common SPD byte 2
......................................................................

include/spd_ddr2: Remove common SPD byte 2

Common SPD byte 2 is defined in include/spd.h

Change-Id: I29cf4184a32e9e72c1927b8f1f70f099394974af
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/include/spd_ddr2.h
1 file changed, 2 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/29725/1

diff --git a/src/include/spd_ddr2.h b/src/include/spd_ddr2.h
index 724c996..447ba89 100644
--- a/src/include/spd_ddr2.h
+++ b/src/include/spd_ddr2.h
@@ -18,9 +18,8 @@
 #define __SPD_DDR2_H__
 
 /* SPDs for DDR2 SDRAM */
-#define SPD_MEM_TYPE	2
-	#define SPD_MEM_TYPE_SDRAM_DDR	0x07
-	#define SPD_MEM_TYPE_SDRAM_DDR2	0x08
+
+/* SPD Byte [2] memory type, see include/spd.h: spd_memory_type enum */
 
 #define SPD_DIMM_TYPE	20	/* x  bit0 or bit4 =1 mean registered*/
 	#define SPD_DIMM_TYPE_RDIMM	0x01

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29725
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29cf4184a32e9e72c1927b8f1f70f099394974af
Gerrit-Change-Number: 29725
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181120/2214a7f3/attachment.html>


More information about the coreboot-gerrit mailing list