[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: Bring DISPLAY_MTRRS into the light

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/29684 )

Change subject: soc/intel/common: Bring DISPLAY_MTRRS into the light
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/29684/2/src/Kconfig
File src/Kconfig:

https://review.coreboot.org/#/c/29684/2/src/Kconfig@708
PS2, Line 708: 	depends on HAVE_DISPLAY_MTRRS
Should we maybe consider building a better way for arch/soc/mainboard to add options here? This is heavily x86 specific, as are several others already in here... it's going to get pretty full (especially if you need a dummy HAVE_... option for everything as well).

In Linux they solve this by having a separate Kconfig.debug file next to the normal Kconfig in every subdirectory that offers debug options. We could do the same.



-- 
To view, visit https://review.coreboot.org/29684
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd0a64121bd6e4ab5d7fd835f3ac25d3f5011f24
Gerrit-Change-Number: 29684
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Julius Werner <jwerner at chromium.org>
Gerrit-Comment-Date: Mon, 19 Nov 2018 20:37:13 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181119/0445b483/attachment.html>