[coreboot-gerrit] Change in coreboot[master]: drivers/intel/fsp1_1/cache_as_ram.inc: Dont include soc/car_setup.S
Frans Hendriks (Code Review)
gerrit at coreboot.org
Mon Nov 19 12:04:56 CET 2018
Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/29687
Change subject: drivers/intel/fsp1_1/cache_as_ram.inc: Dont include soc/car_setup.S
......................................................................
drivers/intel/fsp1_1/cache_as_ram.inc: Dont include soc/car_setup.S
soc/car_setup.S is included when SKIP_FSP_CAR is enabled,
but no chipset/SoC have car_setup.S available.
Remove include and post_code() call always solving build errors.
BUG=NA
TEST=NA
Change-Id: Iebae2940eb10c9ca9054437be4740c79137bcc61
Signed-off-by: Frans Hendriks <fhendriks at eltan.com>
---
M src/drivers/intel/fsp1_1/cache_as_ram.inc
1 file changed, 0 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/29687/1
diff --git a/src/drivers/intel/fsp1_1/cache_as_ram.inc b/src/drivers/intel/fsp1_1/cache_as_ram.inc
index af6f3a9..934ae67 100644
--- a/src/drivers/intel/fsp1_1/cache_as_ram.inc
+++ b/src/drivers/intel/fsp1_1/cache_as_ram.inc
@@ -37,19 +37,6 @@
cache_as_ram:
post_code(0x20)
-#if IS_ENABLED(CONFIG_SKIP_FSP_CAR)
-
- /*
- * SOC specific setup
- * NOTE: This has to preserve the registers
- * mm0, mm1 and edi.
- */
- #include <soc/car_setup.S>
-
- post_code(0x28)
-
-#endif
-
/*
* Find the FSP binary in cbfs.
* Make a fake stack that has the return value back to this code.
--
To view, visit https://review.coreboot.org/29687
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iebae2940eb10c9ca9054437be4740c79137bcc61
Gerrit-Change-Number: 29687
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks <fhendriks at eltan.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181119/685bf931/attachment.html>
More information about the coreboot-gerrit
mailing list