[coreboot-gerrit] Change in coreboot[master]: soc/intel/braswell: Add C_ENVIRONMENT_BOOTBLOCK support

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/29662 )

Change subject: soc/intel/braswell: Add C_ENVIRONMENT_BOOTBLOCK support
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/29662/2/src/soc/intel/braswell/romstage/car_stage.S
File src/soc/intel/braswell/romstage/car_stage.S:

https://review.coreboot.org/#/c/29662/2/src/soc/intel/braswell/romstage/car_stage.S@23
PS2, Line 23: 	call	romstage_c_entry
> please replace romstage_c_entry with car_stage_entry of all affected mainboards and get rid of this  […]
I agree that might change filename into car_stage_entry.S, but don't understand your comment:
1. This entry point is called from arch/x86/assembly_entry.S. It will call romstage_c_entry() to continue in romstage. For sure car_stage_entry() can be created in mainboard, but this function will be call to romstage_c_entry() or copy of romstage_c_entry(). Why not generate common support?
2. Or do you call car_stage_c_entry() and replace the romstage_c_entry function with car_stage_c_entry
3. This is same support a skylake (fsp 1.1) implementation.



-- 
To view, visit https://review.coreboot.org/29662
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab48ad72f1514c93f20d70db5ef4fd8fa2383e8c
Gerrit-Change-Number: 29662
Gerrit-PatchSet: 2
Gerrit-Owner: Frans Hendriks <fhendriks at eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks at eltan.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Mon, 19 Nov 2018 09:58:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181119/328b3bce/attachment.html>