[coreboot-gerrit] Change in coreboot[master]: util/board_status: run dmesg with sudo

Patrick Georgi (Code Review) gerrit at coreboot.org
Sun Nov 18 18:12:19 CET 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/29670 )

Change subject: util/board_status: run dmesg with sudo
......................................................................

util/board_status: run dmesg with sudo

Newer kernels only allow root to access the kernel log buffer.
In another case (cbmem) we use sudo to get past that, so we can
expect sudo to be available here, too.

Change-Id: I654422992e5ba1e98a786f65d50289efbcd46602
Signed-off-by: Patrick Georgi <patrick at georgi.software>
Reviewed-on: https://review.coreboot.org/29670
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Angel Pons <th3fanbus at gmail.com>
---
M util/board_status/board_status.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved



diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh
index 4acbb6c..bba3d1f 100755
--- a/util/board_status/board_status.sh
+++ b/util/board_status/board_status.sh
@@ -381,7 +381,7 @@
 	cmd_nonfatal $REMOTE "$cbmem_cmd -t" "${tmpdir}/${results}/coreboot_timestamps.txt"
 
 	echo "Getting remote dmesg"
-	cmd $REMOTE dmesg "${tmpdir}/${results}/kernel_log.txt"
+	cmd $REMOTE sudo dmesg "${tmpdir}/${results}/kernel_log.txt"
 else
 	echo "Verifying that CBMEM is available"
 	if [ $(id -u) -ne 0 ]; then

-- 
To view, visit https://review.coreboot.org/29670
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I654422992e5ba1e98a786f65d50289efbcd46602
Gerrit-Change-Number: 29670
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181118/521f964b/attachment.html>


More information about the coreboot-gerrit mailing list