[coreboot-gerrit] Change in coreboot[master]: util: Fix shebang for python2 scripts

Patrick Georgi (Code Review) gerrit at coreboot.org
Sun Nov 18 10:12:27 CET 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/29666 )

Change subject: util: Fix shebang for python2 scripts
......................................................................

util: Fix shebang for python2 scripts

Python 3 is the default Python interpreter on most modern systems.
Python 2 scripts must specify they should be run with Python 2 in their
shebang. Solves issue raised in CB:28953.

Change-Id: I9ace4afd668539c05e7ace30e255af50c7a069c2
Signed-off-by: Angel Pons <th3fanbus at gmail.com>
Reviewed-on: https://review.coreboot.org/29666
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
---
M util/cavium/devicetree_convert.py
M util/ipqheader/createxbl.py
M util/ipqheader/mbn_tools.py
M util/lint/checkpatch_json.py
4 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved



diff --git a/util/cavium/devicetree_convert.py b/util/cavium/devicetree_convert.py
old mode 100644
new mode 100755
index 656fdf6..827e5a7
--- a/util/cavium/devicetree_convert.py
+++ b/util/cavium/devicetree_convert.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python2
 
 # devicetree_convert Tool to convert a DTB to a static C file
 # Copyright (C) 2018 Facebook Inc.
diff --git a/util/ipqheader/createxbl.py b/util/ipqheader/createxbl.py
index 7f2d987..1efd8ba 100755
--- a/util/ipqheader/createxbl.py
+++ b/util/ipqheader/createxbl.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python2
 #============================================================================
 #
 #/** @file createxbl.py
diff --git a/util/ipqheader/mbn_tools.py b/util/ipqheader/mbn_tools.py
index 8a17563..c66afda 100755
--- a/util/ipqheader/mbn_tools.py
+++ b/util/ipqheader/mbn_tools.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python2
 #===============================================================================
 #
 # MBN TOOLS
diff --git a/util/lint/checkpatch_json.py b/util/lint/checkpatch_json.py
index 74ad96a..c8dd36d 100755
--- a/util/lint/checkpatch_json.py
+++ b/util/lint/checkpatch_json.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python2
 # Copyright (C) 2018 Intel Corporation.
 # written by Naresh G Solanki<naresh.solanki at intel.com> and
 #            Maulik V Vaghela <maulik.v.vaghela at intel.com>

-- 
To view, visit https://review.coreboot.org/29666
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ace4afd668539c05e7ace30e255af50c7a069c2
Gerrit-Change-Number: 29666
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181118/28d525c9/attachment.html>


More information about the coreboot-gerrit mailing list