[coreboot-gerrit] Change in coreboot[master]: Kconfig: Unify power-after-failure options
Nico Huber (Code Review)
gerrit at coreboot.org
Sun Nov 18 02:43:40 CET 2018
Nico Huber has posted comments on this change. ( https://review.coreboot.org/29680 )
Change subject: Kconfig: Unify power-after-failure options
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/29680/1/src/mainboard/Kconfig
File src/mainboard/Kconfig:
https://review.coreboot.org/#/c/29680/1/src/mainboard/Kconfig@198
PS1, Line 198: config POWER_STATE_DEFAULT_OFF_AFTER_FAILURE
Should get rid of this and invert the default, only intel/soc/common/
doesn't set it.
https://review.coreboot.org/#/c/29680/1/src/mainboard/Kconfig@208
PS1, Line 208: default POWER_STATE_ON_AFTER_FAILURE
Should mention that this can be overridden by an option-table entry.
--
To view, visit https://review.coreboot.org/29680
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61259f864c8a8cfc7099cc2699059f972fa056c0
Gerrit-Change-Number: 29680
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 18 Nov 2018 01:43:40 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181118/69ecf2ce/attachment.html>
More information about the coreboot-gerrit
mailing list