[coreboot-gerrit] Change in coreboot[master]: util/abuild: Use absolute paths for (failed|passed)_boards

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/29451 )

Change subject: util/abuild: Use absolute paths for (failed|passed)_boards
......................................................................


Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/29451/4/util/abuild/abuild
File util/abuild/abuild:

https://review.coreboot.org/#/c/29451/4/util/abuild/abuild@22
PS4, Line 22: TOP
> any reason why you couldn't just derive the full paths from $TOP?
Don't know what $TOP is used for at all. The original problem,
{failed,passed}_boards, is relative to $TARGET so that can't work.

(now that I looked, half of the script seems to use $TOP as root
of the coreboot tree, the other half $ROOT and assumes abuild might
be called from somewhere else)

Maybe it could be used for some paths that I normalized to use
abspath(). Idk, for somebody who didn't wrote this script, it's
hard to grasp in which directory it is at which point. Some of
the calls to `pwd` on the LHS might be unnecessary, who knows?



-- 
To view, visit https://review.coreboot.org/29451
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief00e28e09a4714b0106c35ad4f4e9c696f6aad4
Gerrit-Change-Number: 29451
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 17 Nov 2018 16:25:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181117/b1c3b324/attachment.html>